lkml.org 
[lkml]   [2008]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT] HID patches for 2.6.28
On Tue, 14 Oct 2008, Linus Torvalds wrote:

> The new Kconfig options are almost uselessly described, and very
> annoying and this adds several new warnings of the type:
> drivers/hid/hid-lg.c:342: warning: ?hid_compat_logitech? defined but not used
> which is just unacceptable.

Hmm, this is because of Harvey Harrison's (CC added) patch that was used
to silence sparse warning, but it is wrong as Jiri correctly pointed out
on http://lkml.org/lkml/2008/9/4/495 but I somehow completely missed that
mail.

Will fix that up.

> As to the Kconfig options - do they really add so much space that you
> need to ask for the quirks? You didn't use to. Can you make the
> questions depend on EMBEDDED, or at least on the HID_COMPAT thing or
> whatever?

Probably makes sense, yes. I will send you a new pull request.

--
Jiri Kosina


\
 
 \ /
  Last update: 2008-10-14 22:15    [W:0.054 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site