Messages in this thread | | | Date | Tue, 14 Oct 2008 16:15:07 +0200 | From | Andi Kleen <> | Subject | Re: Please pull arch perfmon update |
| |
On Tue, Oct 14, 2008 at 04:05:50PM +0200, Robert Richter wrote: > On 13.10.08 22:29:51, Andi Kleen wrote: > > > I added a follow on patch (446223f) on branch arch-perfmon that > > > > I didn't do that intentionally because it's called too late. > > The function really has to be called early, so that the fallback > > works. > > The hook is in op_nmi_init() and directly called after > arch_perfmon_init() and before init_sysfs(). Only > register_cpu_notifier() and the setup of oprofile_operations are in > between. This should work.
The problem is that arch perfmon init should only be called after the other initialization function failed.
So you would need a chain of op_x86_model_spec for fallback.
It's simpler and cleaner to just write that out in explicit C.
-Andi
| |