Messages in this thread Patch in this message | | | Date | Mon, 13 Oct 2008 22:29:31 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] x86: split e820 reserved entries record to late v4 - fix v7 |
| |
On Mon, Oct 13, 2008 at 1:32 PM, Tony Luck <tony.luck@intel.com> wrote: > On Thu, Sep 4, 2008 at 12:22 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote: >> On Thu, Sep 4, 2008 at 12:16 PM, Andrew Morton >> <akpm@linux-foundation.org> wrote: >>> On Thu, 4 Sep 2008 21:04:57 +0200 >>> Ingo Molnar <mingo@elte.hu> wrote: >>> >>>> + printk(KERN_DEBUG " __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n", >>>> + conflict->name, conflict->start, conflict->end, >>>> + name, start, end); >>>
Ingo, how come following patch getting lost?
commit 1cf44baad76b6f20f95ece397c6f643320aa44c9 Author: Ingo Molnar <mingo@elte.hu> Date: Thu Sep 4 21:26:06 2008 +0200
IO resources: fix/remove printk
Andrew Morton noticed that the printk in kernel/resource.c was buggy:
| start and end have type resource_size_t. Such types CANNOT be printed | unless cast to a known type. | | Because there is a %s following an incorrect %lld, the above code will | crash the machine.
... and it's probably quite unneeded as well, so remove it.
Reported-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/kernel/resource.c b/kernel/resource.c index 414d6fc..fc59dcc 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -549,13 +549,9 @@ static void __init __reserve_region_with_split(struct resource *root, }
if (!res) { - printk(KERN_DEBUG " __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n", - conflict->name, conflict->start, conflict->end, - name, start, end); - /* failed, split and try again */
- /* conflict coverred whole area */ + /* conflict covered whole area */ if (conflict->start <= start && conflict->end >= end) return;
| |