Messages in this thread | | | Date | Mon, 13 Oct 2008 20:09:36 -0300 | From | Henrique de Moraes Holschuh <> | Subject | Re: [patch 17/18] net/rfkill/rfkill-input.c needs <linux/sched.h> |
| |
On Mon, 13 Oct 2008, Henrique de Moraes Holschuh wrote: > On Mon, 13 Oct 2008, Geert Uytterhoeven wrote: > > | net/rfkill/rfkill-input.c: In function 'rfkill_start': > > | net/rfkill/rfkill-input.c:208: error: dereferencing pointer to incomplete type > > > > As the incomplete type is `struct task_struct', including <linux/sched.h> fixes > > it. > > Line 208 is this (in latest Linus mainline and also v2.6.27): > > spin_unlock_irq(&handle->dev->event_lock); > > So we need to include sched.h to everything that uses spin_unlock_irq? If
Never mind, I didn't check if the problem is with the argument to spin_unlock_irq(), but the question remains...
> only some variants of m68k need that, shouldn't it have been added on the > header that defines spin_unlock_irq() on those arches, instead? > > Or am I looking at a different version of rfkill-input.c than what you based > that error message on?
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
| |