| From | Alan Cox <> | Subject | [PATCH 27/80] serial_8250: pci_enable_device fail is not fully handled | Date | Mon, 13 Oct 2008 10:36:11 +0100 |
| |
From: Alan Cox <alan@redhat.com>
<rmk> talking about leaks - I noticed that the 'check return of pci_enable_dev()' in the 8250 pci resume function finally made it in pite my objections against it (causing stuff in higher levels to leak).
Signed-off-by: Alan Cox <alan@redhat.com> ---
drivers/serial/8250_pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index c2f2393..c014ffb 100644 --- a/drivers/serial/8250_pci.c +++ b/drivers/serial/8250_pci.c @@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev) * The device may have been disabled. Re-enable it. */ err = pci_enable_device(dev); + /* FIXME: We cannot simply error out here */ if (err) - return err; - + printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n"); pciserial_resume_ports(priv); } return 0;
|