Messages in this thread | | | Date | Sun, 12 Oct 2008 09:59:03 -0400 | From | Jeff Layton <> | Subject | Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset |
| |
On Sun, 12 Oct 2008 08:40:39 -0500 "Steve French" <smfrench@gmail.com> wrote:
> Rafael and Guo-Fu, > The following change to address the compile error that you noted is > slightly different than what you suggested but should fix what you > found. >
Actually, I like Adrian/Rafael's fix better. I think we should avoid cluttering up the code with #ifdef's where possible. key_put() already is a no-op when CONFIG_KEYS is disabled. We might as well do the same thing with key_revoke().
Cheers, -- Jeff Layton <jlayton@redhat.com>
| |