Messages in this thread | | | Date | Sun, 12 Oct 2008 00:48:16 +0200 | From | Willy Tarreau <> | Subject | Re: Looks broken to me: x86, cyrix: debug |
| |
On Sat, Oct 11, 2008 at 10:58:58PM +0200, Ingo Molnar wrote: > > * Maciej W. Rozycki <macro@linux-mips.org> wrote: > > > On Sat, 11 Oct 2008, Alan Cox wrote: > > > > > > +#define getCx86_old(reg) ({ outb((reg), 0x22); inb(0x23); }) > > > > > > Doesn't expand to any kind of returned value. > > > > Well, actually it returns the value of the inb() expression -- cf the > > semantics of compound statements. The rest looks suspicious indeed. > > indeed it's broken - will sort it out. It's all about breakage that has > been in this code since v2.6.20, see c6744955d0. Will likely revert the > whole thing.
In fact the whole commit looks buggy to me as it simply reintroduces the old bug at several places. The correct way of accessing the registers is precisely through the inline functions and never through a macro due to the ordering problem.
Willy
| |