lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] cciss: Fix cciss SCSI rescan code to better notice device changes.
On Fri, Sep 19, 2008 at 05:19:31PM -0700, Andrew Morton wrote:
> On Thu, 18 Sep 2008 15:07:44 -0500
[...]
> y'know, it would be a lot simpler to just do
>
> *sd = *device;
>
> a few lines up, before assigning sd->bus/target/lun.
>
> Putting these:
>
> @@ -66,6 +66,10 @@ struct cciss_scsi_dev_t {
> int devtype;
> int bus, target, lun; /* as presented to the OS */
> unsigned char scsi3addr[8]; /* as presented to the HW */
> + unsigned char device_id[16]; /* from inquiry pg. 0x83 */
> + unsigned char vendor[8]; /* bytes 8-15 of inquiry data */
> + unsigned char model[16]; /* bytes 16-31 of inquiry data */
> + unsigned char revision[4]; /* bytes 32-35 of inquiry data */
> };
>
> into a separate nested structure might make that neater still.
>
[... and a bunch of other helpful comments. ]


Sorry for the slow reply, I've been on vacation.

Thanks for looking over my patch. I'll try to make a
patch to incorporate your suggestions.

> didn't cciss_scsi_add_entry() just do that? I didn't look too closely,
> so maybe it didn't, and we're taking two copies for some reason.
> Please double-chec

I think you're right about that, good catch.

-- steve



\
 
 \ /
  Last update: 2008-10-01 17:15    [W:0.052 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site