Messages in this thread | | | Date | Wed, 9 Jan 2008 14:26:26 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl |
| |
On Wed, 9 Jan 2008, Matthew Wilcox wrote:
> > default: > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > > + unlock_kernel(); > > return -EINVAL; > Surely a bug ... shouldn't this return -ENOTTY?
What POSIX states [1]:
[EINVAL] The request or arg argument is not valid for this device.
[ENOTTY] The fildes argument is not associated with a STREAMS device that accepts control functions.
[1] http://www.opengroup.org/onlinepubs/009695399/functions/ioctl.html
-- Jiri Kosina
| |