lkml.org 
[lkml]   [2008]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
On Wed, 9 Jan 2008, Matthew Wilcox wrote:

> > default:
> > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > + unlock_kernel();
> > return -EINVAL;
> Surely a bug ... shouldn't this return -ENOTTY?

What POSIX states [1]:

[EINVAL]
The request or arg argument is not valid for this device.

[ENOTTY]
The fildes argument is not associated with a STREAMS device that
accepts control functions.

[1] http://www.opengroup.org/onlinepubs/009695399/functions/ioctl.html

--
Jiri Kosina


\
 
 \ /
  Last update: 2008-01-09 14:29    [W:0.072 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site