lkml.org 
[lkml]   [2008]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 06/19] split LRU lists into anon & file sets
On Wed, 02 Jan 2008 17:41:50 -0500
linux-kernel@vger.kernel.org wrote:


> static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> - struct scan_control *sc, int priority)
> + struct scan_control *sc, int priority, int file)
> {
> unsigned long pgmoved;
> int pgdeactivate = 0;
> @@ -1128,64 +1026,65 @@ static void shrink_active_list(unsigned
> struct list_head list[NR_LRU_LISTS];
> struct page *page;
> struct pagevec pvec;
> - int reclaim_mapped = 0;
> - enum lru_list l;
> + enum lru_list lru;
<snip>

> + /*
> + * For sorting active vs inactive pages, we'll use the 'anon'
> + * elements of the local list[] array and sort out the file vs
> + * anon pages below.
> + */

This is not easy to read.... (this definition affects later patches...)

How about adding some new enum (only) for this function ?
like
LRU_STAY_ACTIVE = 0,
LRU_MOVE_INACTIVE = 1,

Thanks,
-Kame



\
 
 \ /
  Last update: 2008-01-07 10:23    [W:0.180 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site