Messages in this thread | | | Date | Mon, 7 Jan 2008 22:10:01 +0100 | From | Marcin Slusarz <> | Subject | Re: [PATCH 4/7] udf: replace loops coded with goto to real loops |
| |
On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: > On Sun 06-01-08 02:21:50, marcin.slusarz@gmail.com wrote: > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > I'm not sure if this improves readability in general. If the code is > really a loop in nature, then we should code it using do {} while but in > case we loop back just in case of some error (as seems to be the case in > udf_bitmap_new_block()), then IMHO goto is more explanative. So at least > that one case I'd leave as is. Why do you think it's an error?
Marcin
| |