Messages in this thread | | | Date | Fri, 04 Jan 2008 22:42:37 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [patch 1/3] move WARN_ON() out of line |
| |
Ingo Molnar wrote: > * Arjan van de Ven <arjan@linux.intel.com> wrote: > > >> +#define WARN_ON(condition) do_warn_on((unsigned long)(condition), __FILE__, \ >> + __LINE__, __FUNCTION__) >> > > hm. This passes in 4 arguments to do_warn_on(). > > i think we could get away with no arguments (!), by using section > tricks. Firstly, we can get rid of __FUNCTION__ and replace it with a > ksyms lookup - that is fine enough. Secondly, we could put __FILE__ and > __LINE__ into a text section and key it up to the return address from > do_warn_on(). >
BUG_ON already does this, and WARN_ON can reuse all the same machinery.
J
| |