Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II | Date | Fri, 4 Jan 2008 13:38:07 +0100 |
| |
On Friday 04 January 2008 10:00:52 Ingo Molnar wrote: > > * Andi Kleen <ak@suse.de> wrote: > > > On x86-64 there are several memory allocations before bootmem. To > > avoid them stomping on each other they used to be all hard coded in > > bad_area(). Replace this with an array that is filled as needed. > > > > This cleans up the code considerably and allows to expand its use. > > this code introduces a number of style errors that make the code harder > to read and follow. Please fix them.
I reviewed the code now and I honestly don't see any "style errors" so I don't know how to change it.
-Andi
| |