Messages in this thread | | | Date | Thu, 31 Jan 2008 18:21:42 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] kill hotplug init/exit section annotations |
| |
On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 09:57:31 -0600 > James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > > > No-one seems to see much value in these, and they cause about 90% of > > our problems with __init/__exit markers, so simply eliminate them. > > Rather than run over the whole tree removing them, this patch > > #defines them to be nops. > > > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> > > > > --- > > > > I'll probably be going after __exit after this one, but it makes sense > > to split them up, since the hotplug annotation removal looks > > uncontroversial, whereas __exit and discard section removal might > > produce more robust debate. I also think doing the hotplug removal > > gives us 90% of the benefits and removes 90% of the section mismatch > > problems. > > > Since hotplug is so fundamental nowadays the value no longer outweighs the pain/cost > to me, so
Granted for normal hotplug.
But my computer has neither CPU hotplug not memory hotplug, and I don't see the point for removing these annotations (and they are anyway not what causes problems in normal drivers).
> Acked-by: Arjan van de Ven <arjan@linux.intel.com>
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |