lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Char: applicom, use pci_match_id
On Wed, 30 Jan 2008 12:13:15 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:

> + if (!pci_match_id(applicom_pci_tbl, dev));
> continue;


The patch was carelessly prepared, was not runtine-tested and was not
passed through checkpatch, which detects this error. Please fix these
things, permanently.

It's hard to overemphasise how out-of-balance the economics are here. You
saved maybe thirty person-seconds by skipping the review and checkpatch
steps. But the cost (if this bug had gone into mainline) would be many
many thousands times higher than this.


\
 
 \ /
  Last update: 2008-01-31 00:13    [W:0.093 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site