Messages in this thread | | | Date | Wed, 30 Jan 2008 15:10:22 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] Char: applicom, use pci_match_id |
| |
On Wed, 30 Jan 2008 12:13:15 +0100 Jiri Slaby <jirislaby@gmail.com> wrote:
> + if (!pci_match_id(applicom_pci_tbl, dev)); > continue;
The patch was carelessly prepared, was not runtine-tested and was not passed through checkpatch, which detects this error. Please fix these things, permanently.
It's hard to overemphasise how out-of-balance the economics are here. You saved maybe thirty person-seconds by skipping the review and checkpatch steps. But the cost (if this bug had gone into mainline) would be many many thousands times higher than this.
| |