lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] teach checkpatch.pl about list_for_each
Em Thu, Jan 03, 2008 at 12:26:10PM +0000, Christoph Hellwig escreveu:
> On Thu, Jan 03, 2008 at 11:10:58AM +0000, Andy Whitcroft wrote:
> > We have had some stabs at changing this, but no consensus was reached on
> > whether it was a "for" or a "function". My memory is of there being
> > slightly more "without a space" tenders than the other and so it has not
> > been changed. This thread also seems so far to have not really
> > generated a concensus. So I would tend to leave things as they are.
> >
> > A third option might be to accept either on *for_each* constructs.
> > That might tend to lead to divergance. Difficult. However, also see my
> > later comments on "style guide".
>
> Pretty much all core code uses list_for_each_entry( so new code should
> follow that example.

Agreed, CodingStyle is not about mindless consistency such as "for (" is
the right thing, so "list_for_each (" is consistent with it, it is about
codifying practice contributors got used to over the years.

- Arnaldo


\
 
 \ /
  Last update: 2008-01-03 13:35    [W:0.058 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site