Messages in this thread | | | Subject | Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5 | From | FUJITA Tomonori <> | Date | Fri, 04 Jan 2008 09:47:22 +0900 |
| |
On Thu, 03 Jan 2008 15:51:25 -0500 David Dillow <dave@thedillows.org> wrote:
> > On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: > > As for a better fix, I'm not sure. > > Here's a better way than the strncmp. If this meets everyone's approval, > then I can roll up a proper commit.
Thanks! I really apprecate it.
I think that this is the root problem and the patch fixes it in the right way. Please send this patch to linux-scsi@vger.kernel.org and a patch to move srp_remove_host before scsi_remove_host in srp_remove_one to Roland.
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c > index 44a340b..65c584d 100644 > --- a/drivers/scsi/scsi_transport_srp.c > +++ b/drivers/scsi/scsi_transport_srp.c > @@ -265,7 +265,8 @@ EXPORT_SYMBOL_GPL(srp_rport_del); > > static int do_srp_rport_del(struct device *dev, void *data) > { > - srp_rport_del(dev_to_rport(dev)); > + if (scsi_is_srp_rport(dev)) > + srp_rport_del(dev_to_rport(dev)); > return 0; > } > >
| |