Messages in this thread | | | Date | Fri, 4 Jan 2008 00:42:58 +0100 | From | "Jesper Juhl" <> | Subject | Re: [PATCH] This patch to printk.c fixes a few errors reported by checkpatch.pl |
| |
On 04/01/2008, Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote: > This patch to printk.c fixes a few errors reported by checkpatch.pl > [...] > - for (a=console_drivers->next, b=console_drivers ; > - a; b=a, a=b->next) { > + for (a = console_drivers->next, b = console_drivers ;
I would say that if you are modifying this line anyway you should make it read
for (a = console_drivers->next, b = console_drivers;
(the change is the removal of the space before the ';' at the end of the line)
otherwise I think it looks sane enough as a small style cleanup.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html
| |