Messages in this thread | | | Subject | Re: [patch 1/2] move WARN_ON() out of line | From | Matt Mackall <> | Date | Thu, 03 Jan 2008 16:27:55 -0600 |
| |
On Thu, 2008-01-03 at 22:26 +0100, Arjan van de Ven wrote: > Subject: move WARN_ON() out of line > From: Arjan van de Ven <arjan@linux.intel.com> > CC: Ingo Molnar <mingo@elte.hu> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: Olof Johansson <olof@lixom.net> > CC: Matt Meckall <mpm@selenic.com> > > A quick grep shows that there are currently 1145 instances of WARN_ON > in the kernel. Currently, WARN_ON is pretty much entirely inlined, > which makes it hard to enhance it without growing the size of the kernel > (and getting Andrew rightfully unhappy). > > This patch build on top of Olof's patch that introduces __WARN, > and places the slowpath out of line. It also uses Ingo's suggestion > to not use __FUNCTION__ but to use kallsyms to do the lookup; > this saves a ton of extra space since gcc doesn't need to store the function > string twice now: > > 3936367 833603 624736 5394706 525112 vmlinux.before > 3917508 833603 624736 5375847 520767 vmlinux-slowpath
Nice!
Acked-by: Matt Mackall <mpm@selenic.com>
-- Mathematics is the supreme nostalgia of our time.
| |