lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages
In message <1199341581.6615.39.camel@localhost>, Joe Perches writes:
> On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote:

> I think printks should be single statements and
> KERN_CONT should be used as sparingly as possible.
[...]

KERN_CONT is documented as not being SMP safe, but I figured it was harmless
for just some debugging message. Still, I like your way better. Thanks
Joe.

> Perhaps:
> pr_debug("IT(%lu:%d): %s:%s:%d "
> "um=%lu/%lu lm=%lu/%lu "
> "uc=%lu/%lu lc=%lu/%lu\n",
> inode->i_ino, bindex, file, fnx, line,
> inode->i_mtime.tv_sec, inode->i_mtime.tv_nsec,
> lower_inode->i_mtime.tv_sec,
> lower_inode->i_mtime.tv_nsec
> inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
> lower_inode->i_ctime.tv_sec,
> lower_inode->i_ctime.tv_nsec);
[...]

Erez.


\
 
 \ /
  Last update: 2008-01-03 19:39    [W:0.042 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site