Messages in this thread | | | Date | Wed, 30 Jan 2008 11:59:43 +0900 (JST) | Subject | Re: [PATCH] Fix NUMA emulation for x86_64 | From | Minoru Usui <> |
| |
>>>>> ">" == Ingo Molnar <mingo@elte.hu> writes:
>> * Minoru Usui <usui@mxm.nes.nec.co.jp> wrote:
>> I found a small bug of NUMA emulation code for x86_64. >> (CONFIG_NUMA_EMU) If machine is non-NUMA, find_node_by_addr() should >> return NUMA_NO_NODE, but current implementation code returns existent >> maximum NUMA node number + 1. This is not existent NUMA node number. >> >> However, this behaviour does not affect NUMA emulation fortunately, >> because acpi_fake_nodes() that is caller of find_node_by_addr() gets >> pxm (proximity domain) by node_to_pxm() from non-existent NUMA node >> number that was returned by find_node_by_addr(). node_to_pxm() returns >> PXM_INVAL that means illegal or non-existent NUMA node number.
>> thanks, i have applied your fix to x86.git.
>> It seems this does not need to be backported to v2.6.24.1 because >> node_to_pxm() masked the bad effects of this bug, right?
>> Ingo
I think this bug is not urgency. If you mean that it's not necessary to release 2.6.24.1 only for this bug, I think so.
| |