Messages in this thread | | | Date | Mon, 28 Jan 2008 19:15:01 -0500 | From | "Mike Frysinger" <> | Subject | Re: [rfc] exposing MMR's of on-chip peripherals for debugging purposes |
| |
On Jan 28, 2008 7:08 PM, Daniel Barkalow <barkalow@iabervon.org> wrote: > On Mon, 28 Jan 2008, Mike Frysinger wrote: > > On Jan 28, 2008 8:04 AM, richard kennedy <richard@rsk.demon.co.uk> wrote: > > > there is a lot of duplication in your file, but you could slim it down a > > > bit if thats the only objection. > > > > i imagine there's a ton of duplication ... the file is auto-generated > > from XML files, so i could take a look at the autogeneration producing > > unified code. > > Could you submit the XML files and the autogeneration code? The C file > isn't really source. Not only is it big, it'll probably change around a > whole lot when you make small changes to your process, be hard to review, > etc.
that would require the build system to have xml tools installed ... that doesnt sound pleasant.
that said, the XML files in question are probably 10x+ the size of the C file. swapping 1 meg for 10+ megs ? :) -mike
| |