Messages in this thread | | | From | Paul Moore <> | Subject | Re: [2.6 patch] security/selinux/netlabel.c: fix double free | Date | Mon, 28 Jan 2008 17:39:12 -0500 |
| |
On Monday 28 January 2008 5:35:40 pm Adrian Bunk wrote: > On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: > > Thanks for finding this mistake, however, I'd rather see it fixed > > by removing the netlbl_secattr_destroy() call in > > security_netlbl_sid_to_secattr() as it really shouldn't be there > > anymore. We moved the matching _init() call into > > selinux_netlbl_sock_setsid() and I'd like to see the _init() and > > _destroy() calls done in the same function. I can push a revised > > patch for this if you would prefer, otherwise I'll be happy to ack > > an updated version ... > > doing the patch is trivial but you are able to write a better > changelog for it - just push a revised patch.
Will do, thanks.
-- paul moore linux security @ hp
| |