Messages in this thread | | | Date | Mon, 28 Jan 2008 13:57:05 -0800 | From | Andrew Morton <> | Subject | Re: [RFC] Per-thread getrusage |
| |
On Mon, 28 Jan 2008 13:43:02 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote:
> Pavel Emelyanov <xemul@openvz.org> writes: > >> ... > >> +asmlinkage long sys_thread_getrusage(int tid, struct rusage __user *ru) > >> +{ > >> + struct task_struct *tsk; > >> + tsk = find_task_by_pid(tid); > >> + return getrusage(tsk, RUSAGE_THREAD, ru); > >> +} > > > > Well, the find_task_by_pid() is really wrong here. > > And find_task_by_pid should probably just be removed.
That's what I was thinking.
> No need to provide function with the gun firmly pointed at our feet....
It still has a disturbingly large number of callers.
| |