Messages in this thread Patch in this message | | | Date | Mon, 28 Jan 2008 19:52:36 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] x86: fix usage of .section .sched.text in assembler code |
| |
On Mon, Jan 28, 2008 at 11:13:34AM +0100, Ingo Molnar wrote: > > > It would be better to have a definition we could use from assembler > > code but I did not find a suitable header file for it. > > hm, include/asm-x86/linkage.h? No - it is for general use so it should live in include/linux/* Suggestion:
diff --git a/include/linux/linkage.h b/include/linux/linkage.h index ff203dd..4ac87bf 100644 --- a/include/linux/linkage.h +++ b/include/linux/linkage.h @@ -48,6 +48,15 @@ END(name); \ .popsection +#define SCHED_ENTRY(name) \ + .pushsection .sched.text, "ax", %progbits; \ + ENTRY(name) + +#define SCHED_END(name) \ + END(name); \ + .popsection + + #ifndef END #define END(name) \ .size name, .-name
Note - the use of '%' is due to '@' is a comment identifier on arm and '%' seems to works across all arch's assemblers.
> > btw., i guess this in include/linux/linkage.h: > > #ifndef __ALIGN > #define __ALIGN .align 4,0x90 > #define __ALIGN_STR ".align 4,0x90" > #endif > > is an x86-ism (0x90 is the x86 NOP instruction) that should move into > include/asm-x86/linkge.h and the default filler should be 0x00 instead? To specialized for my knowledge..
Sam
| |