lkml.org 
[lkml]   [2008]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek
Date
On Monday 28 January 2008 14:38:57 Alan Cox wrote:
> > Also worse really fixing it would be a major change to the VFS
> > because of the way ->read/write are defined :/
>
> I don't see a problem there. ->read and ->write update the passed pointer
> which is not the real f_pos anyway. Just the copies need fixing.

They are effectually doing a decoupled read/modify/write cycle. e.g.:

A B

read fpos

read fpos

fpos += A fpos += B
write fpos


write fpos

So you get overlapping reads. Probably not good.

-Andi


\
 
 \ /
  Last update: 2008-01-28 15:13    [W:0.295 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site