Messages in this thread | | | Date | Mon, 28 Jan 2008 21:38:57 +0900 | From | "minchan kim" <> | Subject | Re: [PATCH] remove duplicating priority setting in try_to_free_p |
| |
I agree with you. If you will have a test result, Let me know it.
On Jan 28, 2008 6:01 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Mon, 28 Jan 2008 15:43:56 +0900 "minchan kim" <minchan.kim@gmail.com> wrote: > > > > I think this is actually a bugfix. The code you're removing doesn't do the > > > > > > if (priority < zone->prev_priority) > > > > > > thing. > > > > > > > shrink_zones() in try_to_free_pages() already called > > note_zone_scanning_priority(). > > So, it have done it. > > note_zone_scanning_priority() will only permit ->prev_priority to logically > increase, whereas the code which you've removed will also permit > ->prev_priority to logically decrease. So I don't see that they are > equivalent? > >
-- Kinds regards, barrios
| |