Messages in this thread | | | Date | Mon, 28 Jan 2008 00:57:36 +0100 | From | "Paolo Ciarrocchi" <> | Subject | Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2 |
| |
On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote: > > On Jan 27, 2008 11:42 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > * Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote: > > > > > Looks like it would be better to proceed in the following manner: > > > > > > 1) remove dead code (no md5 change); > > > 2) reformat the lines to use tabs, not spaces (no md5 change); > > > 3) address the "else-braces" and "single statement block" errors > > > (no md5 change); > > > 4) remove all unnecessary spaces (no md5 change); > > > 5) add the KERN_ macros (md5 will change). > > > 6) address remaining checkpatch complaints (no md5 change wrt #5 > > > above). > > > > > > Each item above might get into a separate patch. > > > > agreed, that looks like a sensible splitup for such larger cleanup > > patches. > > > > (also, a debug switch that disabled the FPU on modern CPUs and which > > forced math-emu would be nice as well.) > > OK, I'll do what you both suggested.
Mmh... I wonder why if I strip the files I get the same md5sum: paolo@paolo-desktop:~/linux-2.6/kernel$ strip /home/paolo/Desktop/File\ punto\ o/* paolo@paolo-desktop:~/linux-2.6/kernel$ md5sum /home/paolo/Desktop/File\ punto\ o/* 2bf404e247edf33cf6fb99c37321cdb9 /home/paolo/Desktop/File punto o/error.o.after 2bf404e247edf33cf6fb99c37321cdb9 /home/paolo/Desktop/File punto o/error.o.before
How should I compare the .o file? Simply doing a md5sum or should I do a objdump -d before? Or a strip?
Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/
| |