Messages in this thread | | | Date | Sun, 27 Jan 2008 23:01:04 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c |
| |
* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
> On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote: > > > - math_abort(FPU_info,SIGILL); > > > + math_abort(FPU_info , SIGILL); > > > > Looks like you're trading bad for worse here. > > Should I make it read like math_abort(FPU_info, SIGILL); ?
yeah, that's the correct one.
> > While you're at it, please think about adding proper KERN_ facility to these printk() calls. > > Yes, basically all the warnings are about missing KERN_. Do you want > me to add KERN_ERR to all the above printk?
Do that in a separate patch though, as it changes strings. (and hence the checking for 'did the object md5 change' misfires)
Ingo
| |