| From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 25/32] ide-tape: simplify code branching in the interrupt handler | Date | Sun, 27 Jan 2008 20:42:11 +0100 |
| |
On Sunday 27 January 2008, Borislav Petkov wrote: > From: Borislav Petkov <bbpetkov@yahoo.de> > > ... by adding a new typedef function pointer idetape_io_buf in order to call > the proper buffer i/o handler depending on the data direction. > > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> > --- > drivers/ide/ide-tape.c | 54 +++++++++++++++++++++++++---------------------- > 1 files changed, 29 insertions(+), 25 deletions(-)
[...]
> +typedef void idetape_io_buf(ide_drive_t *, idetape_pc_t *, uint);
'uint' -> 'unsigned int'
[...]
Otherwise this patch is fine but depends on other patches needing rework (please move it near the beginning of the series).
Thanks, Bart
|