Messages in this thread | | | From | Stefan Roese <> | Subject | Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c | Date | Sat, 26 Jan 2008 14:37:33 +0100 |
| |
On Thursday 24 January 2008, Josh Boyer wrote: > On Wed, 23 Jan 2008 23:37:33 +0100 > > Roel Kluin <12o3l@tiscali.nl> wrote: > > logical/bitand typo > > > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > > --- > > diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > > index ebf9e21..dcfb459 100644 > > --- a/arch/powerpc/boot/4xx.c > > +++ b/arch/powerpc/boot/4xx.c > > @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void) > > val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT); > > cs = 0; > > while (val) { > > - if (val && 0x1) > > + if (val & 0x1) > > cs++; > > val = val >> 1; > > } > > Hm, good catch. > > Stefan, have you had problems with this code at all?
I'm not using the bootwrapper on a 4xx with Denali core.
Best regards, Stefan
| |