lkml.org 
[lkml]   [2008]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/52] [microblaze] kernel modules support

On Jan 24 2008 16:02, monstr@monstr.eu wrote:
>+
>+/* module handling */
>+EXPORT_SYMBOL(PAGE_OFFSET);

This looks really ugly. PAGE_OFFSET is usually a macro.
I looked in patch 29/52 where PAGE_OFFSET is defined (unsigned int
PAGE_OFFSET), which got me wondered: PAGE_OFFSET can be a runtime
variable when it is a constant on most other arches?

That being said, I'd use

#define PAGE_OFFSET __page_offset

in some header file and in the .c file:

unsigned int __page_offset;
EXPORT_SYMBOL(__page_offset);

that is how arch-frv and -uml seem to do it.



\
 
 \ /
  Last update: 2008-01-26 17:31    [W:0.157 / U:2.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site