Messages in this thread | | | From | Len Brown <> | Subject | Re: DMI: create dmi_get_slot() | Date | Fri, 25 Jan 2008 15:19:09 -0500 |
| |
On Friday 25 January 2008 15:13, Wim Van Sebroeck wrote: > Hi Len, > > I saw you added the dmi_get_slot function recently. > If I look in drivers/firmware/dmi_scan.c however I now see: > > ... > > /** > * dmi_get_system_info - return DMI data value > * @field: data index (see enum dmi_field) > * > * Returns one DMI data value, can be used to perform > * complex DMI data checks. > */ > const char *dmi_get_system_info(int field) > { > return dmi_ident[field]; > } > EXPORT_SYMBOL(dmi_get_system_info); > > ... > > /** > * dmi_get_slot - return dmi_ident[slot] > * @slot: index into dmi_ident[] > */ > char *dmi_get_slot(int slot) > { > return(dmi_ident[slot]); > } > > Didn't we duplicate code here?
Yep, thanks for noticing, i'll delete the duplicate.
-Len
| |