Messages in this thread | | | Subject | Re: [patch 01/26] mount options: add documentation | From | Miklos Szeredi <> | Date | Fri, 25 Jan 2008 11:02:48 +0100 |
| |
> Where did you check for the existence of a ->show_options method for > unionfs? Unionfs does implement ->show_options and supports all of the > mount/remount options. See: > > <http://git.kernel.org/?p=linux/kernel/git/ezk/unionfs.git;a=blob;f=fs/unionfs/super.c;h=986c980261a5b171147d66ac05bf08423e2fd6b6;hb=HEAD#l963> > > The unionfs ->remount code supports branch-management options which can > add/del/change a branch, but we don't show those directly in ->show_options; > it makes more sense to show the final (and thus most current) branch > configuration. > > Could you update your records please?
Sure. Sorry about that, I did actually look at unionfs, and it was just an administration error and bad memory (in my head).
> BTW, I should be able to use your save_mount_options().
It is probably better not to use save_mount_options(). Especially, since unionfs implemets a remount, that changes the tree only partially AFAICS.
Miklos
| |