lkml.org 
[lkml]   [2008]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 10/26] mount options: fix devpts
From
Date
> > Also add minor fix: when parsing the "mode" option, mask with
> > S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
> > mask.
>
> umode_t is 16 bits, so it doesn't. The change is still good, of course.

We still use 16 bit types? Strange ;)

>
> > + if (config.mode != DEVPTS_DEFAULT_MODE)
> > + seq_printf(seq, ",mode=%03o", config.mode);
>
> I would rather this be unconditional, than that it be conditional on
> something other than the user having specified it in the first place.

Yeah, it's a matter of taste. I'll update the patch.

Actually, a lot of filesystems share the options 'uid=X', 'gid=X',
'mode=X' (or 'umask=X'). This could be handled by the VFS, saving
some code, and making things more consistent. One day maybe...

Thanks,
Miklos


\
 
 \ /
  Last update: 2008-01-25 10:27    [W:0.142 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site