lkml.org 
[lkml]   [2008]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 113/196] Kobject: change drivers/cpufreq/cpufreq.c to use kobject_init_and_add
    Date
    Stop using kobject_register, as this way we can control the sending of
    the uevent properly, after everything is properly initialized.

    Cc: Dominik Brodowski <linux@brodo.de>
    Cc: Ashok Raj <ashok.raj@intel.com>
    Cc: Jacob Shin <jacob.shin@amd.com>
    Cc: Kay Sievers <kay.sievers@vrfy.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/cpufreq/cpufreq.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    index 79581fa..9e102af 100644
    --- a/drivers/cpufreq/cpufreq.c
    +++ b/drivers/cpufreq/cpufreq.c
    @@ -828,11 +828,8 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
    memcpy(&new_policy, policy, sizeof(struct cpufreq_policy));

    /* prepare interface data */
    - policy->kobj.parent = &sys_dev->kobj;
    - policy->kobj.ktype = &ktype_cpufreq;
    - kobject_set_name(&policy->kobj, "cpufreq");
    -
    - ret = kobject_register(&policy->kobj);
    + ret = kobject_init_and_add(&policy->kobj, &ktype_cpufreq, &sys_dev->kobj,
    + "cpufreq");
    if (ret) {
    unlock_policy_rwsem_write(cpu);
    goto err_out_driver_exit;
    @@ -902,6 +899,7 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
    goto err_out_unregister;
    }

    + kobject_uevent(&policy->kobj, KOBJ_ADD);
    module_put(cpufreq_driver->owner);
    dprintk("initialization complete\n");
    cpufreq_debug_enable_ratelimit();
    --
    1.5.3.8


    \
     
     \ /
      Last update: 2008-01-25 09:07    [W:4.025 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site