Messages in this thread | | | Date | Thu, 24 Jan 2008 21:38:56 +1100 | From | Ben Nizette <> | Subject | Re: [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32 |
| |
Haavard Skinnemoen wrote: > On Wed, 23 Jan 2008 22:53:54 +1100 > Ben Nizette <bn@niasdigital.com> wrote: > >> /* >> + * We just keep an empty definition of this around (a-la the asm-generic >> + * implementation) to keep /dev/mem happy >> + */ >> +#define unxlate_dev_mem_ptr(p, a) {} > > Thanks, but this should be either > > #define unxlate_dev_mem_ptr(p, a) do { } while (0) > > or > > static inline void unxlate_dev_mem_ptr(unsigned long phys, void *addr) > { > } > > I prefer the latter.
Yeah I don't know what came over me; Mia culpa :-)
I prefer the latter too, though I think I was striving for consistency with the xlate_dev_mem_ptr #define.
--Ben
| |