lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 30/49] ext4: Convert truncate_mutex to read write semaphore.
    > On Mon, 21 Jan 2008 22:02:09 -0500 "Theodore Ts'o" <tytso@MIT.EDU> wrote:
    > +int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, sector_t block,
    > + unsigned long max_blocks, struct buffer_head *bh,
    > + int create, int extend_disksize)
    > +{
    > + int retval;
    > + if (create) {
    > + down_write((&EXT4_I(inode)->i_data_sem));
    > + } else {
    > + down_read((&EXT4_I(inode)->i_data_sem));
    > + }
    > + if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) {
    > + retval = ext4_ext_get_blocks(handle, inode, block, max_blocks,
    > + bh, create, extend_disksize);
    > + } else {
    > + retval = ext4_get_blocks_handle(handle, inode, block,
    > + max_blocks, bh, create, extend_disksize);
    > + }
    > + if (create) {
    > + up_write((&EXT4_I(inode)->i_data_sem));
    > + } else {
    > + up_read((&EXT4_I(inode)->i_data_sem));
    > + }

    This function has many unneeded braces. checkpatch used to detect this
    but it seems to have broken.

    > + return retval;
    > +}
    > static int ext4_get_block(struct inode *inode, sector_t iblock,
    > struct buffer_head *bh_result, int create)

    Mising newline.


    \
     
     \ /
      Last update: 2008-01-23 23:15    [W:3.101 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site