lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/20 -v5] add notrace annotations for NMI routines


On Wed, 23 Jan 2008, Mathieu Desnoyers wrote:

> * Steven Rostedt (rostedt@goodmis.org) wrote:
> > This annotates NMI functions with notrace. Some tracers may be able
> > to live with this, but some cannot. So we turn off NMI tracing.
> >
> > One solution might be to make a notrace_nmi which would only turn
> > off NMI tracing if a trace utility needed it off.
> >
> Is this still needed with the atomic clocksource read ?

This never had to do with the clocksource. The tracer itself isn't atomic
against NMIs. hmm, it may actually be. It does a tracer disable for the
CPU by an atomic_inc and this would prevent the NMI from causing harm.

I'll test without this patch and see what happens when I turn on a high
rate of NMIS.

I still want to add a bit more notraces around for the simple
reason of cleaning up the output and prehaps speeding up the code a bit.

-- Steve



\
 
 \ /
  Last update: 2008-01-23 23:01    [W:0.076 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site