Messages in this thread | | | Date | Tue, 22 Jan 2008 21:29:44 -0800 | From | Arjan van de Ven <> | Subject | Re: [patch] x86: test case for the RODATA config option |
| |
On Wed, 23 Jan 2008 12:11:41 +1100 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > #ifdef CONFIG_DEBUG_RODATA > > > > +const int rodata_test_data = 5; > > I guess this should match the 32-bit case, and be zero instead of > 5?
actually it should have been 5 for both (well any non-zero number) > > Can you disallow building as a module, and put this in the test > code? It could be run from the end of mark_rodata_ro()...
fair; I was developing it as a module (just easier) but yeah it makes more sense as part of mark_rodata_ro(). I'll do that in the next rev
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |