Messages in this thread | | | Date | Tue, 22 Jan 2008 09:44:12 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH 1/6] driver-core : add class iteration api |
| |
On Tue, 22 Jan 2008 15:27:08 +0800, Dave Young <hidave.darkstar@gmail.com> wrote:
> On Mon, Jan 21, 2008 at 10:24:17PM -0800, David Brownell wrote: > > This is called with class->sem held. So fn() has a > > constraint to not re-acquire that ... else it'd be > > self-deadlocking. I'd like to see docs at least > > mention that; calls to add or remove class members > > would be verboten, for example, which isn't an issue > > with most other driver model iterators.
Indeed, it's a good idea to point this out.
> Update kerneldoc as david brownell's sugestion. > Is it right for me add Cornelia Huck's ack after this change?
Fine with me.
> --- > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <hidave.darkstar@gmail.com> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> > > --- > drivers/base/class.c | 175 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/device.h | 11 ++- > 2 files changed, 184 insertions(+), 2 deletions(-)
| |