Messages in this thread | | | Date | Fri, 18 Jan 2008 16:56:50 +0100 | From | Ingo Molnar <> | Subject | Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_attr patch series v3) |
| |
* Ingo Molnar <mingo@elte.hu> wrote:
> hm, i just found a failing 64-bit .config while testing your CPA > patchset: > > [ 1.916541] CPA mapping 4k 0 large 2048 gb 0 x 0[0-0] miss 0 > [ 1.919874] Unable to handle kernel paging request at 000000000335aea8 RIP: > [ 1.919874] [<ffffffff8021d2d3>] change_page_attr+0x3/0x61 > [ 1.919874] PGD 0 > [ 1.919874] Oops: 0000 [1] > [ 1.919874] CPU 0 > > config and full crash.log attached. Fully reproducible. I've also > pushed out the current x86.git with the new CPA bits included.
hm, and your CPA queue is no bisectable, due to:
Subject: Undo pat cpa patch From: Andi Kleen <ak@suse.de>
Going to implement this differently
commit 5ec5c5a2302ca8794da03f8bedec931a2a814ae9 Author: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> Date: Tue Jan 15 09:36:03 2008 +0100
patches/x86-pat-cpa_i386.patch
could you please make your queue bisectable?
Also, did you actually try to port your queue ontop of the cleanups patch? There's an easy technique: first do an undo patch, then apply your patch, then apply the re-do patch. Whatever rejects come from the re-do patch can be dropped from the cleanup. Continue with this until all patches are covered. Then generate the undo+your-old-patch+redo patch into a single your-new-patch.
Ingo
| |