Messages in this thread | | | Subject | Re: [PATCH -v6 1/2] Massive code cleanup of sys_msync() | From | Miklos Szeredi <> | Date | Fri, 18 Jan 2008 10:33:51 +0100 |
| |
> unsigned long end; > - struct mm_struct *mm = current->mm; > + int error, unmapped_error; > struct vm_area_struct *vma; > - int unmapped_error = 0; > - int error = -EINVAL; > + struct mm_struct *mm; > > + error = -EINVAL;
I think you may have misunderstood my last comment. These are OK:
struct mm_struct *mm = current->mm; int unmapped_error = 0; int error = -EINVAL;
This is not so good:
int error, unmapped_error;
This is the worst:
int error = -EINVAL, unmapped_error = 0;
So I think the original code is fine as it is.
Othewise patch looks OK now.
Miklos
| |