Messages in this thread | | | Date | Tue, 15 Jan 2008 11:31:43 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D |
| |
Hi Steve,
On Mon, 14 Jan 2008 22:28:51 +0000, Steve Hardy wrote: > > As far as I know boolean parameters take values 0 and 1, not N and Y. > > Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface > displays boolean parameters as Y/N, and will accept boot parameters as > either Y/N or 0/1. Below is a snippet from a test proving this point : > > test@shtest:~$ cat /sys/module/ads7828/parameters/se_input > Y > test@shtest:~$ cat /sys/module/ads7828/parameters/int_vref > Y > > after appending the ads7828.int_vref=N parameter to the kernel > command-line : > > Linux 2.6.24-rc6 (shtest) (16:53 on Saturday, 05 January 2002) > > login: test > test@shtest:~$ cat /sys/module/ads7828/parameters/int_vref > N
Oh. This is news to me, thanks for the information.
> Is it more "correct" to refer to 1/0 in the documentation? > I just naturally used the same syntax provided by the sysfs nodes
Nah, just scratch this comment of mine, I just didn't know that Y/N was working for booleans. If you prefer that to document that form that's alright with me.
(I do believe that it was a mistake to allow two different ways to do the same thing, but that's a different issue.)
-- Jean Delvare
| |