Messages in this thread | | | Date | Tue, 15 Jan 2008 14:22:53 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86_64: checking aperture report for node instead of cpu |
| |
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> - printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n", > - num-24, aper_base, aper_size>>20); > + printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n", > + node++, aper_base, aper_size >> 20);
please dont put side-effects into printks. (put the node++ iteration out into a separate line) Your patch looks fine otherwise.
Ingo
| |