lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 4/5] memory_pressure_notify() caller
Hi KAME, 

> > + notify_threshold = (zone->pages_high +
> > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2;
> > +
> Why MAX_NR_ZONES-1 ?

this is intent to max lowmem_reserve.

in normal case,
shrink_active_list isn't called when free_pages > pages_high.
but just after memory freed, it happened rarely.

I don't want incorrect notify at system enough free memory.

related discussion
http://marc.info/?l=linux-mm&m=119878630211348&w=2


> > + if (unlikely((prev_free <= notify_threshold) &&
> > + (zone_page_state(zone, NR_FREE_PAGES) > notify_threshold)))
> > + memory_pressure_notify(zone, 0);
> > }
>
> How about this
> ==
> if (unlikely(zone->mem_notify_status && ...)

Nice idea.
I will applied it at next post.

thank you!






\
 
 \ /
  Last update: 2008-01-15 03:41    [W:0.090 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site