Messages in this thread Patch in this message | | | Date | Mon, 14 Jan 2008 15:35:06 -0600 | From | Eric Sandeen <> | Subject | [PATCH] hfs: fix coverity-found null deref |
| |
Fix potential null deref introduced by commit cf0594625083111ae522496dc1c256f7476939c2 http://bugzilla.kernel.org/show_bug.cgi?id=9748
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: linux-2.6.24-rc6-mm1/fs/hfs/btree.c =================================================================== --- linux-2.6.24-rc6-mm1.orig/fs/hfs/btree.c +++ linux-2.6.24-rc6-mm1/fs/hfs/btree.c @@ -61,7 +61,7 @@ struct hfs_btree *hfs_btree_open(struct mapping = tree->inode->i_mapping; page = read_mapping_page(mapping, 0, NULL); if (IS_ERR(page)) - goto free_tree; + goto free_inode; /* Load the header */ head = (struct hfs_btree_header_rec *)(kmap(page) + sizeof(struct hfs_bnode_desc)); @@ -107,11 +107,12 @@ struct hfs_btree *hfs_btree_open(struct page_cache_release(page); return tree; - fail_page: +fail_page: page_cache_release(page); - free_tree: +free_inode: tree->inode->i_mapping->a_ops = &hfs_aops; iput(tree->inode); +free_tree: kfree(tree); return NULL; }
| |