Messages in this thread | | | Date | Mon, 14 Jan 2008 20:50:28 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/2] checkstack: parse architecture correctly |
| |
On 01/14/2008 08:19 PM, Stephen Hemminger wrote: > The checkstack script wouldn't work because it was picking up the > newline on the end of the output of uname -m. > > Also, use a standard perl construct to print error message and > exit with non-zero error code. > > Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com> > > --- a/scripts/checkstack.pl 2008-01-14 11:09:09.000000000 -0800 > +++ b/scripts/checkstack.pl 2008-01-14 11:09:51.000000000 -0800 [...] > - print("wrong or unknown architecture\n"); > - exit > + die "wrong or unknown architecture\"$arch\"\n";
a space before the variable would be good, maybe qq() instead of "" to avoid backslashing? Also the \n is reduntant there, otherwise you will loose the file+line info.
| |