Messages in this thread | | | Date | Mon, 14 Jan 2008 19:12:43 +0000 | From | Andy Whitcroft <> | Subject | Re: [PATCH] checkpatch.pl: show how to read from stdin |
| |
On Mon, Jan 14, 2008 at 09:35:15AM -0800, Daniel Walker wrote: > > On Mon, 2008-01-14 at 17:17 +0000, Andy Whitcroft wrote: > > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > > > Acked-by: Jiri Slaby <jirislaby@gmail.com> > > > > As an absolute minimum this seems reasonable to me. I guess we could > > make no arguments default to '-' also. There are up and downsides to > > doing that, as currently no arguments currently tell you the usage and > > with this patch would point clearly out the '-' option. Just assuming > > stding would lose easy access to usage, which may actually be more > > confusing for the beginner. Hmmm. Cirtainly will include this > > documentation change if nothing else. > > > > The patch that I submitted checks STDIN for piped data, and if there is > any it will default to checking that incoming data .. That's regardless > of the number of arguments given ..
So it does, however that of itself differs from the unix norm; as with this I cannot run checkpatch and "type" (ie paste) a patch fragment to check it. So I don't think we want the semantics as you have there, as its confusing to the experienced user and inconsistent with the norm. Either we should document the standard '-' usage as has been suggested elsewhere or always assume stdin with no parameters.
-apw
| |