lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16
Jan Engelhardt wrote:
> On Jan 13 2008 10:34, travis@sgi.com wrote:
>> --- a/arch/x86/kernel/mpparse_64.c
>> +++ b/arch/x86/kernel/mpparse_64.c
>> @@ -132,7 +132,7 @@ static void __cpuinit MP_processor_info(
>> * area is created.
>> */
>> if (x86_cpu_to_apicid_ptr) {
>> - u8 *x86_cpu_to_apicid = (u8 *)x86_cpu_to_apicid_ptr;
>> + u16 *x86_cpu_to_apicid = (u16 *)x86_cpu_to_apicid_ptr;
>> x86_cpu_to_apicid[cpu] = m->mpc_apicid;
>> } else {
>> per_cpu(x86_cpu_to_apicid, cpu) = m->mpc_apicid;
>
> You can do away with the cast while modifying this line.

Thanks! For some reason I had problems with the 'inter-section'
referencing and this slipped in while addressing that problem.

>
>> --- a/arch/x86/mm/srat_64.c
>> +++ b/arch/x86/mm/srat_64.c
>> @@ -384,6 +388,12 @@ int __init acpi_scan_nodes(unsigned long
>> }
>>
>> #ifdef CONFIG_NUMA_EMU
>> +static int fake_node_to_pxm_map[MAX_NUMNODES] __initdata = {
>> + [0 ... MAX_NUMNODES-1] = PXM_INVAL
>> +};
>> +static unsigned char fake_apicid_to_node[MAX_LOCAL_APIC] __initdata = {
>> + [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
>> +};
>> static int __init find_node_by_addr(unsigned long addr)
>> {
>> int ret = NUMA_NO_NODE;
>
> No u8/u16 here?

Good point.

Thanks,
Mike



\
 
 \ /
  Last update: 2008-01-14 19:25    [W:0.057 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site